Agile & Delivery playbook/Module 7 · Engineering practices

Day 63 / 100 · Engineering practices · Code review

Small, fast, and kind.

Code review catches defects and spreads knowledge. It fails when pull requests are huge, reviews are slow, or feedback is about style.

Small pull requests

A Few Hundred Lines

Easy to understand in one sitting.

Big PRs get rubber-stamped, not reviewed.

Fast turnaround

Within A Day

Review before starting something new.

Waiting PRs are work in progress too.

The right things

Let Tools Do The Rest

Correctness, security, clarity.

Formatting and style belong to linters.

Small, fast, kind, and about what matters.